test: add figure-8 GVEC golden validation#331
Merged
krystophny merged 1 commit intofeature/boozer-chartmap-gvec-qafrom Mar 28, 2026
Merged
test: add figure-8 GVEC golden validation#331krystophny merged 1 commit intofeature/boozer-chartmap-gvec-qafrom
krystophny merged 1 commit intofeature/boozer-chartmap-gvec-qafrom
Conversation
Member
Author
|
Routing this one to @Rykath for GVEC/QUASR review, with @krystophny as SIMPLE-maintainer follow-up once the lower stack is in. |
krystophny
force-pushed
the
feature/boozer-chartmap-qa
branch
from
3796c9d to
22f7dcb
Compare
krystophny
force-pushed
the
feature/boozer-chartmap-gvec
branch
from
4a70c36 to
1de68f3
Compare
krystophny
force-pushed
the
feature/boozer-chartmap-qa
branch
from
22f7dcb to
6ab1d6b
Compare
krystophny
force-pushed
the
feature/boozer-chartmap-gvec
branch
from
1de68f3 to
38115fc
Compare
krystophny
force-pushed
the
feature/boozer-chartmap-gvec
branch
from
38115fc to
da4c2e2
Compare
krystophny
force-pushed
the
feature/boozer-chartmap-qa
branch
from
6ab1d6b to
47b52cc
Compare
krystophny
force-pushed
the
feature/boozer-chartmap-gvec
branch
from
da4c2e2 to
8a16303
Compare
krystophny
force-pushed
the
feature/boozer-chartmap-qa
branch
from
47b52cc to
081965f
Compare
krystophny
changed the title
krystophny
force-pushed
the
feature/boozer-chartmap-qa
branch
from
081965f to
0c5aa94
Compare
krystophny
force-pushed
the
feature/boozer-chartmap-gvec
branch
from
f97010a to
17361f3
Compare
krystophny
force-pushed
the
feature/boozer-chartmap-gvec
branch
from
17361f3 to
e621d9a
Compare
krystophny
force-pushed
the
feature/boozer-chartmap-gvec
branch
from
ff50bad to
6844d3f
Compare
krystophny
changed the title
krystophny
changed the base branch from
main
to
feature/boozer-chartmap-gvec-qa
krystophny
merged commit 3a42c9b
into
feature/boozer-chartmap-gvec-qa
7 of 8 checks passed
krystophny
added a commit
that referenced
this pull request
Mar 28, 2026
## Summary Add the full GVEC and real-Cartesian Boozer chartmap layer on top of the VMEC validation stack. This PR now absorbs the old top PR 327. The real-Cartesian contract belongs here, because this is the first layer where the generalized non-cylindrical Boozer toroidal parameter actually matters end to end. This layer adds: - GVEC state -> Boozer chartmap NetCDF conversion - real-Cartesian `x,y,z` export for the Boozer grid instead of the earlier pseudo-Cartesian embedding - `zeta_convention='boozer'` fixtures and refreshed QA/figure-8 chartmaps on that contract - QA common-case VMEC/GVEC comparison on the shared chartmap path - figure-8 QUASR/GVEC golden validation and reviewer plots - benchmark/artifact helpers used by the end-to-end GVEC coverage - CI installation of `gvec` for the slow GVEC-backed Python tests ## Stack - base: `feature/boozer-chartmap-qa` - head: `feature/boozer-chartmap-gvec` ## Validation scope in this PR - shared QA case across: 1. direct VMEC Boozer 2. VMEC-exported Boozer chartmap 3. GVEC-exported Boozer chartmap - figure-8 QUASR -> GVEC -> Boozer chartmap -> SIMPLE golden validation ## Review Primary GVEC/QUASR review: @Rykath SIMPLE-maintainer follow-up: @krystophny
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the figure-8 QUASR -> GVEC -> Boozer chartmap golden-validation layer on top of the shared QA GVEC benchmark.
This slice adds:
Stack
feature/boozer-chartmap-gvec-qafeature/boozer-chartmap-gvecReview
Primary GVEC/QUASR review: @Rykath
SIMPLE-maintainer follow-up: @krystophny
Verification